Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add edb_sqlpatch information on minor version up page for EPAS 15 manual #4861

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Add edb_sqlpatch information on minor version up page for EPAS 15 manual #4861

merged 2 commits into from
Oct 3, 2023

Conversation

yuki-tei
Copy link
Contributor

Hi team,
Greetings.

We've found that your minor upgrade page lacks the information about edb_sqlpatch description, which is needed for example v15.4.

What Changed?

Add edb_sqlpatch command sample and link to its manual page at bottom.

djw-m
djw-m reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very unclear. The instructions don't instruct you to run edb_sqlpatch, but you are supposed to take action based on it's result?

Does any of the preceding steps run edb_sqlpatch automatically? If not, shouldn't there be a patching step?

Happy to discuss.

@yuki-tei
Copy link
Contributor Author

Hi,
Thanks for your quick reply. Apologies for my description might be confusing.

The most important point for this page is that edb_sqlpatch doesn't exist till 15.4.
So the newbee for EDB might look into this minor update instruction page and doesn't aware of the need to apply edb_sqlpatch.

So the idea was first to at least give a link for edb_sqlpatch on this page.
However, even do so, especially the new customers might not know in which case they need edb_sqlpatch post minor release, one idea as you see is to decide by edb_sqlpatch's command result itself. If you have any other ideas, please tell us.

Thanks for your kind advice.
Regards,
Yuki Tei

@djw-m djw-m added the deploy Add this label to a PR and it will automatically be deployed to netlify label Oct 2, 2023
@djw-m
Copy link
Contributor

djw-m commented Oct 2, 2023 •
edited
Loading

So, these instructions should read...

!!! Important

If on version 15.4 or later, you should run edb_sqlpatch

If the command responds that it has a number of patches needing to be applied like so:

* database edb
0 patches were previously applied to this database.
58 patches need to be applied to this database.

Then it will be necessary to execute edb_sqlpatch to patch the system catalog. Run:

edb_sqlpatch -af

!!!

@yuki-tei
Copy link
Contributor Author

yuki-tei commented Oct 2, 2023

Hi,

Thanks for your quick review and proofreading.
We believe that makes sense and would be a great help to many customers.
Appreciates to your continuous help.

Kind Regards,
Yuki Tei

@djw-m
Copy link
Contributor

djw-m commented Oct 3, 2023

@nidhibhammar This change will need back-porting to refer to 11.21.32, 12.16.20, 13.12.17 and 14.9.0 if we merge it.

nidhibhammar
nidhibhammar approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@nidhibhammar nidhibhammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree with back-porting.

@djw-m djw-m merged commit c5e4a6a into EnterpriseDB:develop Oct 3, 2023
1 check passed
@yuki-tei yuki-tei deleted the patch-4 branch October 10, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djw-m djw-m djw-m left review comments

@nidhibhammar nidhibhammar nidhibhammar approved these changes

Assignees
No one assigned
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuki-tei @djw-m @nidhibhammar